Improve database connection reliability and session management#160
Merged
Improve database connection reliability and session management#160
Conversation
hacktobeer
approved these changes
Mar 12, 2026
Contributor
hacktobeer
left a comment
There was a problem hiding this comment.
LGTM with one small comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented connection health checks and scoped database sessions to the message processing lifecycle to prevent stale connections and resource leaks.
This fixes an issue where the GCS importer would get broken connections to the postgres container.
Technical Details:
pool_pre_ping=Trueto the SQLAlchemy engine configuration insrc/datastores/sql/database.py. This ensures the engine tests the validity of a connection before using it, automatically reconnecting if the database server has closed the socket.database.SessionLocal()inside thecallbackfunction, the system now creates and closes a fresh session for every message processed.mainexecution loop. This change eliminates the risk of connection timeouts in long-running subscriber processes and removes the need for manual session closing in thefinallyblock.